From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [PATCH 0/6] IRQFD without IRQ routing, enabled for XICS Date: Thu, 7 Aug 2014 19:49:20 +1000 Message-ID: <20140807094920.GC28639@iris.ozlabs.ibm.com> References: <1404125474-18611-1-git-send-email-paulus@samba.org> <53E0CD99.9020906@redhat.com> <53E22111.3040902@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, "Michael S. Tsirkin" , Alexander Graf , Eric Auger To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <53E22111.3040902@redhat.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Aug 06, 2014 at 02:35:29PM +0200, Paolo Bonzini wrote: > This doesn't build without CONFIG_KVM_XICS, so I had to apply a fixup > patch to move some code from being under CONFIG_HAVE_KVM_IRQCHIP or > unconditional, to being conditional on CONFIG_HAVE_KVM_IRQFD. I'll send > the patch shortly. Oops, sorry, thanks for fixing it up. > Also, please look into adding a trace_kvm_set_irq call to kvm_set_irq in > arch/powerpc/kvm/book3s_xics.c. > > I would have preferred these snags to be fixed before (especially since > the breakage is simply with "make ppc64_defconfig"), but it's partly my > fault for delaying the review for so long. And the series is good work ... and I have been on vacation for the past three weeks, which didn't help either. > and a very nice cleanup of the irqfd architecture. > > Assuming that the linux-next merge from tomorrow is fine, I'll send the > second pull request to Linus. Thanks, Paul.