From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "Zhangjie (HZ)" <zhangjie14@huawei.com>,
kvm@vger.kernel.org, netdev@vger.kernel.org,
qinchuanyu@huawei.com, liuyongan@huawei.com, davem@davemloft.net
Subject: Re: Query: Is it possible to lose interrupts between vhost and virtio_net during migration?
Date: Sun, 17 Aug 2014 12:22:33 +0200 [thread overview]
Message-ID: <20140817102233.GC21622@redhat.com> (raw)
In-Reply-To: <53ED76A4.4090005@redhat.com>
On Fri, Aug 15, 2014 at 10:55:32AM +0800, Jason Wang wrote:
> >>> I wonder if k->set_guest_notifiers should be called after "hdev->started = true;" in vhost_dev_start.
> >> Michael, can we just remove those assertions? Since you may want to set
> >> guest notifiers before starting the backend.
> > Which assertions?
>
> I mean assert(hdev->started) in vhost.c. Your patch may hit them.
I don't follow, but since my patch doesn't help anyway, pls go ahead
and post your idea in form of a patch, will be clearer and can
be tested.
next prev parent reply other threads:[~2014-08-17 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53DA2CCC.1040606@huawei.com>
[not found] ` <20140731143100.GA3834@redhat.com>
[not found] ` <20140731143725.GA3875@redhat.com>
2014-08-01 2:17 ` Query: Is it possible to lose interrupts between vhost and virtio_net during migration? Zhangjie (HZ)
[not found] ` <53DB705F.2000405@redhat.com>
[not found] ` <53DB76A9.8010305@redhat.com>
[not found] ` <53E079C8.7050700@huawei.com>
[not found] ` <20140805094957.GB24619@redhat.com>
2014-08-05 12:14 ` Zhangjie (HZ)
2014-08-07 12:47 ` Zhangjie (HZ)
2014-08-14 8:52 ` Jason Wang
2014-08-14 10:02 ` Michael S. Tsirkin
2014-08-15 2:55 ` Jason Wang
2014-08-17 10:22 ` Michael S. Tsirkin [this message]
2014-08-18 5:23 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140817102233.GC21622@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=liuyongan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=qinchuanyu@huawei.com \
--cc=zhangjie14@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox