From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Zickus Subject: Re: [PATCH 3/5] watchdog: fix print-once on enable Date: Mon, 18 Aug 2014 11:07:22 -0400 Message-ID: <20140818150722.GR49576@redhat.com> References: <1407768567-171794-1-git-send-email-dzickus@redhat.com> <1407768567-171794-4-git-send-email-dzickus@redhat.com> <20140818090757.GC25495@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, kvm@vger.kernel.org, pbonzini@redhat.com, mingo@redhat.com, LKML , Ulrich Obergfell , Andrew Jones To: Ingo Molnar Return-path: Content-Disposition: inline In-Reply-To: <20140818090757.GC25495@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, Aug 18, 2014 at 11:07:57AM +0200, Ingo Molnar wrote: > > * Don Zickus wrote: > > > --- a/kernel/watchdog.c > > +++ b/kernel/watchdog.c > > @@ -522,6 +522,9 @@ static void watchdog_nmi_disable(unsigned int cpu) > > /* should be in cleanup, but blocks oprofile */ > > perf_event_release_kernel(event); > > } > > + if (cpu == 0) > > + /* watchdog_nmi_enable() expects this to be zero initially. */ > > + cpu0_err = 0; > > return; > > } > > While at it I also removed the stray 'return;'. Doh, sorry about that. Thanks! Cheers, Don