From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanpeng Li Subject: Re: [PATCH v4] KVM: vmx: fix ept reserved bits for 1-GByte page Date: Wed, 20 Aug 2014 16:38:34 +0800 Message-ID: <20140820083833.GA27197@kernel> References: <1408519913-8943-1-git-send-email-wanpeng.li@linux.intel.com> <53F45893.6050305@redhat.com> Reply-To: Wanpeng Li Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , Gleb Natapov , Zhang Yang , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <53F45893.6050305@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Aug 20, 2014 at 10:13:07AM +0200, Paolo Bonzini wrote: >Il 20/08/2014 09:31, Wanpeng Li ha scritto: >> EPT misconfig handler in kvm will check which reason lead to EPT >> misconfiguration after vmexit. One of the reasons is that an EPT >> paging-structure entry is configured with settings reserved for >> future functionality. However, the handler can't identify if >> paging-structure entry of reserved bits for 1-GByte page are >> configured, since PDPTE which point to 1-GByte page will reserve >> bits 29:12 instead of bits 7:3 which are reserved for PDPTE that >> references an EPT Page Directory. This patch fix it by reserve >> bits 29:12 for 1-GByte page. > >Thanks, the patch looks good. > >Can you describe how you detected the problem and how you're testing for it? > I found the issue by reviewing codes. Regards, Wanpeng Li >Paolo