From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Khlebnikov Subject: [PATCH] kvm tools: balloon: fix overflow in PFN to address conversion Date: Wed, 20 Aug 2014 18:37:34 +0400 Message-ID: <20140820143734.3909.97343.stgit@buzz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Pekka Enberg , Sasha Levin Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:16367 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbaHTOho (ORCPT ); Wed, 20 Aug 2014 10:37:44 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NAM0050U0RNI960@mailout2.w1.samsung.com> for kvm@vger.kernel.org; Wed, 20 Aug 2014 15:40:35 +0100 (BST) Sender: kvm-owner@vger.kernel.org List-ID: Fix trivial overflow of u32 value Signed-off-by: Konstantin Khlebnikov --- tools/kvm/virtio/balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kvm/virtio/balloon.c b/tools/kvm/virtio/balloon.c index f7dfb0b..84c4bb0 100644 --- a/tools/kvm/virtio/balloon.c +++ b/tools/kvm/virtio/balloon.c @@ -64,7 +64,7 @@ static bool virtio_bln_do_io_request(struct kvm *kvm, struct bln_dev *bdev, stru for (i = 0 ; i < len ; i++) { void *guest_ptr; - guest_ptr = guest_flat_to_host(kvm, ptrs[i] << VIRTIO_BALLOON_PFN_SHIFT); + guest_ptr = guest_flat_to_host(kvm, (u64)ptrs[i] << VIRTIO_BALLOON_PFN_SHIFT); if (queue == &bdev->vqs[VIRTIO_BLN_INFLATE]) { madvise(guest_ptr, 1 << VIRTIO_BALLOON_PFN_SHIFT, MADV_DONTNEED); bdev->config.actual++;