From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wanpeng Li <wanpeng.li@linux.intel.com>
Subject: Re: [PATCH] KVM: x86: fix xen guest panic due to lack of
 KVM_REQ_EVENT
Date: Mon, 25 Aug 2014 17:08:22 +0800
Message-ID: <20140825090822.GA4955@kernel>
References: <1408953506-7289-1-git-send-email-wanpeng.li@linux.intel.com>
 <53FAFB53.7040806@redhat.com>
Reply-To: Wanpeng Li <wanpeng.li@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Gleb Natapov <gleb@kernel.org>,
	Zhang Yang <yang.z.zhang@intel.com>, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <53FAFB53.7040806@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Hi Paolo,
On Mon, Aug 25, 2014 at 11:01:07AM +0200, Paolo Bonzini wrote:
>Il 25/08/2014 09:58, Wanpeng Li ha scritto:
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index c10408e..b7c0073 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -4928,6 +4928,8 @@ static void toggle_interruptibility(struct kvm_vcpu *vcpu, u32 mask)
>>  		if (!mask)
>>  			kvm_make_request(KVM_REQ_EVENT, vcpu);
>>  	}
>> +	if (!(int_shadow || mask))
>> +		kvm_make_request(KVM_REQ_EVENT, vcpu);
>>  }
>>  
>>  static void inject_emulated_exception(struct kvm_vcpu *vcpu)
>
>No, this patch undoes the optimization in the buggy patch.
>
>A KVM_REQ_EVENT must be missing somewhere else.
>

Could you give some tips in order that I can figure it out?

Regards,
Wanpeng Li 

>Paolo