From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH v3 5/7] KVM: trace kvm_ple_window grow/shrink
Date: Mon, 25 Aug 2014 16:32:57 +0200
Message-ID: <20140825143256.GB11024@potion.brq.redhat.com>
References: <1408637291-18533-1-git-send-email-rkrcmar@redhat.com>
 <1408637291-18533-6-git-send-email-rkrcmar@redhat.com>
 <20140825135341.GA20218@kria>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	Gleb Natapov <gleb@kernel.org>,
	Raghavendra KT <raghavendra.kt@linux.vnet.ibm.com>,
	Vinod Chegu <chegu_vinod@hp.com>,
	Hui-Zhi Zhao <hui-zhi.zhao@hp.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Lisa Mitchell <lisa.mitchell@hp.com>
To: Sabrina Dubroca <sd@queasysnail.net>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20140825135341.GA20218@kria>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

2014-08-25 15:53+0200, Sabrina Dubroca:
> Hello,
>=20
> 2014-08-21, 18:08:09 +0200, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
> > Tracepoint for dynamic PLE window, fired on every potential change.
> > +#define trace_kvm_ple_window_grow(vcpu_id, new, old) \
> > +	trace_kvm_ple_window(true, vcpu_id, new, old)
> > +#define trace_kvm_ple_window_shrink(vcpu_id, new, old) \
> > +	trace_kvm_ple_window(false, vcpu_id, new, old)
> > +
> >  #endif /* CONFIG_X86_64 */
>=20
> Looks like these are needed on 32-bit as well.
> Today's linux-next doesn't build:
>=20
> [...]
>=20
> I moved the line
>=20
> #endif /* CONFIG_X86_64 */
>=20
> above
>=20
> TRACE_EVENT(kvm_ple_window,
>=20
> and it builds.

Thanks!

Paolo, can you still fix this "just" by rebasing?

---
diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
index 1742dfb..4c2868f 100644
--- a/arch/x86/kvm/trace.h
+++ b/arch/x86/kvm/trace.h
@@ -848,6 +848,8 @@ TRACE_EVENT(kvm_track_tsc,
 		  __print_symbolic(__entry->host_clock, host_clocks))
 );
=20
+#endif /* CONFIG_X86_64 */
+
 TRACE_EVENT(kvm_ple_window,
 	TP_PROTO(bool grow, unsigned int vcpu_id, int new, int old),
 	TP_ARGS(grow, vcpu_id, new, old),
@@ -878,8 +880,6 @@ TRACE_EVENT(kvm_ple_window,
 #define trace_kvm_ple_window_shrink(vcpu_id, new, old) \
 	trace_kvm_ple_window(false, vcpu_id, new, old)
=20
-#endif /* CONFIG_X86_64 */
-
 #endif /* _TRACE_KVM_H */
=20
 #undef TRACE_INCLUDE_PATH