From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: GET_RNG_SEED hypercall ABI? (Re: [PATCH v5 0/5] random,x86,kvm: Rework arch RNG seeds and get some from kvm) Date: Thu, 28 Aug 2014 17:17:04 +0300 Message-ID: <20140828141704.GI18167@minantech.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Bonzini , Theodore Ts'o , "H. Peter Anvin" , kvm list , "linux-kernel@vger.kernel.org" , Kees Cook , X86 ML , Daniel Borkmann , Srivatsa Vaddagiri , Raghavendra K T , Bandan Das , Andrew Honig , KY Srinivasan , Haiyang Zhang , Konrad Rzeszutek Wilk , Alok Kataria , virtualization@lists.linux-foundation.org To: Andy Lutomirski Return-path: Received: from mail-we0-f178.google.com ([74.125.82.178]:59607 "EHLO mail-we0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbaH1ORL (ORCPT ); Thu, 28 Aug 2014 10:17:11 -0400 Received: by mail-we0-f178.google.com with SMTP id u57so848657wes.37 for ; Thu, 28 Aug 2014 07:17:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Aug 26, 2014 at 04:58:34PM -0700, Andy Lutomirski wrote: > hpa pointed out that the ABI that I chose (an MSR from the KVM range > and a KVM cpuid bit) is unnecessarily KVM-specific. It would be nice > to allocate an MSR that everyone involved can agree on and, rather > than relying on a cpuid bit, just have the guest probe for the MSR. > CPUID part allows feature to be disabled for machine compatibility purpose during migration. Of course interface can explicitly state that one successful use of the MSR does not mean that next use will not result in a #GP, but that doesn't sound very elegant and is different from any other MSR out there. -- Gleb.