From: Marcelo Tosatti <mtosatti@redhat.com>
To: Xiao Guangrong <xiaoguangrong.eric@gmail.com>
Cc: kvm@vger.kernel.org, ak@linux.intel.com, pbonzini@redhat.com,
gleb@kernel.org, avi.kivity@gmail.com
Subject: Re: [patch 4/4] KVM: MMU: pinned sps are not candidates for deletion.
Date: Tue, 9 Sep 2014 12:41:27 -0300 [thread overview]
Message-ID: <20140909154127.GC4153@amt.cnet> (raw)
In-Reply-To: <1C17FA2A-5EFB-46D8-A105-CCC31B4BCFC6@linux.vnet.ibm.com>
On Tue, Jul 22, 2014 at 05:59:42AM +0800, Xiao Guangrong wrote:
>
> On Jul 10, 2014, at 3:12 AM, mtosatti@redhat.com wrote:
>
> > Skip pinned shadow pages when selecting pages to zap.
>
> It seems there is no way to prevent changing pinned spte on
> zap-all path?
Xiao,
The way would be to reload remote mmus, forcing the vcpu to exit,
zapping a page, then vcpu will pagefault any necessary page via
kvm_mmu_pin_pages.
kvm_mmu_invalidate_zap_all_pages does:
- spin_lock(mmu_lock)
- kvm_reload_remote_mmus
...
- spin_unlock(mmu_lock)
So its OK to change pinned spte on zap all path.
> I am thing if we could move pinned spte to another list (eg. pinned_shadow_pages)
> instead of active list so that it can not be touched by any other free paths.
> Your idea?
As mentioned it above, it is ok to zap pinned sptes as long w
reload remote mmus request is performed.
That said, you still consider a separate list?
next prev parent reply other threads:[~2014-09-09 15:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 19:12 [patch 0/4] KVM: support for pinning sptes (v2) mtosatti
2014-07-09 19:12 ` [patch 1/4] KVM: x86: add pinned parameter to page_fault methods mtosatti
2014-07-09 19:12 ` [patch 2/4] KVM: MMU: allow pinning spte translations (TDP-only) mtosatti
2014-07-17 17:18 ` Nadav Amit
2014-07-17 21:38 ` Marcelo Tosatti
2014-07-24 12:16 ` Nadav Amit
2014-07-21 21:46 ` Xiao Guangrong
2014-07-22 5:26 ` Xiao Guangrong
2014-07-09 19:12 ` [patch 3/4] KVM: MMU: reload request from GET_DIRTY_LOG path mtosatti
2014-07-21 13:14 ` Gleb Natapov
2014-09-09 15:28 ` Marcelo Tosatti
2014-09-22 17:19 ` Marcelo Tosatti
2014-09-30 18:59 ` Marcelo Tosatti
2014-10-04 7:23 ` Gleb Natapov
2014-10-06 17:19 ` Marcelo Tosatti
2014-10-08 6:56 ` Gleb Natapov
2014-10-08 17:15 ` Marcelo Tosatti
2014-10-08 17:59 ` Gleb Natapov
2014-10-08 19:22 ` Marcelo Tosatti
2014-10-10 13:09 ` Gleb Natapov
2014-10-13 8:52 ` Marcelo Tosatti
2014-10-15 8:03 ` Gleb Natapov
2014-07-21 21:55 ` Xiao Guangrong
2014-09-09 15:35 ` Marcelo Tosatti
2014-07-09 19:12 ` [patch 4/4] KVM: MMU: pinned sps are not candidates for deletion mtosatti
2014-07-21 21:59 ` Xiao Guangrong
2014-09-09 15:41 ` Marcelo Tosatti [this message]
2014-09-22 17:17 ` Marcelo Tosatti
2014-09-23 5:30 ` Xiao Guangrong
2014-07-09 19:20 ` [patch 0/4] KVM: support for pinning sptes (v2) Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909154127.GC4153@amt.cnet \
--to=mtosatti@redhat.com \
--cc=ak@linux.intel.com \
--cc=avi.kivity@gmail.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox