From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH v2] ARM/arm64: KVM: fix use of WnR bit in kvm_is_write_fault() Date: Thu, 11 Sep 2014 05:12:36 +0200 Message-ID: <20140911031236.GL2784@lvm> References: <1410258429-17090-1-git-send-email-ard.biesheuvel@linaro.org> <540EDE63.6060904@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ard Biesheuvel , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , "peter.maydell@linaro.org" , "lersek@redhat.com" To: Marc Zyngier Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:49375 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753341AbaIKDMi (ORCPT ); Wed, 10 Sep 2014 23:12:38 -0400 Received: by mail-pa0-f46.google.com with SMTP id kq14so5944842pab.5 for ; Wed, 10 Sep 2014 20:12:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <540EDE63.6060904@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Sep 09, 2014 at 12:02:59PM +0100, Marc Zyngier wrote: > [resending, as ARM email server seems to be in some mood] > > On 09/09/14 11:27, Ard Biesheuvel wrote: > > The ISS encoding for an exception from a Data Abort has a WnR > > bit[6] that indicates whether the Data Abort was caused by a > > read or a write instruction. While there are several fields > > in the encoding that are only valid if the ISV bit[24] is set, > > WnR is not one of them, so we can read it unconditionally. > > > > Instead of fixing both implementations of kvm_is_write_fault() > > in place, reimplement it just once using kvm_vcpu_dabt_iswrite(), > > which already does the right thing with respect to the WnR bit. > > Also fix up the callers to pass 'vcpu' > > > > Acked-by: Laszlo Ersek > > Signed-off-by: Ard Biesheuvel > > Because I like that kind of diffstat: > Acked-by: Marc Zyngier > > Christoffer, if you too are happy with that, I'll queue it right away. > Extremely happy: Acked-by: Christoffer Dall Thanks, -Christoffer