From: Gleb Natapov <gleb@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
David Matlack <dmatlack@google.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] kvm: don't take vcpu mutex for obviously invalid vcpu ioctls
Date: Tue, 23 Sep 2014 09:49:18 +0300 [thread overview]
Message-ID: <20140923064918.GE30733@minantech.com> (raw)
In-Reply-To: <5420788F.9050208@redhat.com>
On Mon, Sep 22, 2014 at 09:29:19PM +0200, Paolo Bonzini wrote:
> Il 22/09/2014 21:20, Christian Borntraeger ha scritto:
> > "while using trinity to fuzz KVM, we noticed long stalls on invalid ioctls. Lets bail out early on invalid ioctls". or similar?
>
> Okay. David, can you explain how you found it so that I can make up my
> mind?
>
> Gleb and Marcelo, a fourth and fifth opinion? :)
>
I agree with Christian that simpler fix is better here.
The overhead is minimal. If we ever notice this overhead
we can revert the patch all together since the problem it
fixes can only be inflicted on userspace by itself and there
are myriads other ways userspace can hurt itself.
--
Gleb.
next prev parent reply other threads:[~2014-09-23 6:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 23:03 [PATCH] kvm: don't take vcpu mutex for obviously invalid vcpu ioctls David Matlack
2014-09-22 10:50 ` Paolo Bonzini
2014-09-22 13:45 ` Christian Borntraeger
2014-09-22 14:31 ` Paolo Bonzini
2014-09-22 18:35 ` David Matlack
2014-09-22 19:20 ` Christian Borntraeger
2014-09-22 19:29 ` Paolo Bonzini
2014-09-23 6:49 ` Gleb Natapov [this message]
2014-09-23 8:06 ` Christian Borntraeger
2014-09-23 8:23 ` Paolo Bonzini
2014-09-22 19:40 ` David Matlack
2014-09-22 20:08 ` Marcelo Tosatti
2014-09-22 21:29 ` Paolo Bonzini
2014-09-22 23:00 ` Marcelo Tosatti
2014-09-22 22:58 ` David Matlack
2014-09-23 0:13 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923064918.GE30733@minantech.com \
--to=gleb@kernel.org \
--cc=borntraeger@de.ibm.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox