From: Andrea Arcangeli <aarcange@redhat.com>
To: Andres Lagar-Cavilla <andreslc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Gleb Natapov <gleb@kernel.org>,
kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: Fix kvm_get_page_retry_io __gup retval check
Date: Fri, 26 Sep 2014 00:34:04 +0200 [thread overview]
Message-ID: <20140925223404.GB4590@redhat.com> (raw)
In-Reply-To: <1411684010-883-1-git-send-email-andreslc@google.com>
On Thu, Sep 25, 2014 at 03:26:50PM -0700, Andres Lagar-Cavilla wrote:
> Confusion around -EBUSY and zero (inside a BUG_ON no less).
>
> Reported-by: AndreA Arcangeli <aarcange@redhat.com>
> Signed-off-by: Andres Lagar-Cavilla <andreslc@google.com>
> ---
> virt/kvm/kvm_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
Valid for this and the previous patch in Message-Id:
<1410976308-7683-1-git-send-email-andreslc@google.com> as well.
Thanks,
Andrea
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 3f16f56..a1cf53e 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1146,7 +1146,7 @@ int kvm_get_user_page_io(struct task_struct *tsk, struct mm_struct *mm,
> npages = __get_user_pages(tsk, mm, addr, 1, flags, pagep, NULL,
> &locked);
> if (!locked) {
> - VM_BUG_ON(npages != -EBUSY);
> + VM_BUG_ON(npages);
>
> if (!pagep)
> return 0;
> --
> 2.1.0.rc2.206.gedb03e5
>
next prev parent reply other threads:[~2014-09-25 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 22:26 [PATCH] kvm: Fix kvm_get_page_retry_io __gup retval check Andres Lagar-Cavilla
2014-09-25 22:34 ` Andrea Arcangeli [this message]
2014-09-26 8:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925223404.GB4590@redhat.com \
--to=aarcange@redhat.com \
--cc=andreslc@google.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox