From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrea Arcangeli Subject: Re: [PATCH] kvm: Fix kvm_get_page_retry_io __gup retval check Date: Fri, 26 Sep 2014 00:34:04 +0200 Message-ID: <20140925223404.GB4590@redhat.com> References: <1411684010-883-1-git-send-email-andreslc@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Bonzini , Gleb Natapov , kvm@vger.kernel.org To: Andres Lagar-Cavilla Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27967 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551AbaIYWeJ (ORCPT ); Thu, 25 Sep 2014 18:34:09 -0400 Content-Disposition: inline In-Reply-To: <1411684010-883-1-git-send-email-andreslc@google.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Sep 25, 2014 at 03:26:50PM -0700, Andres Lagar-Cavilla wrote: > Confusion around -EBUSY and zero (inside a BUG_ON no less). > > Reported-by: AndreA Arcangeli > Signed-off-by: Andres Lagar-Cavilla > --- > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Andrea Arcangeli Valid for this and the previous patch in Message-Id: <1410976308-7683-1-git-send-email-andreslc@google.com> as well. Thanks, Andrea > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 3f16f56..a1cf53e 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -1146,7 +1146,7 @@ int kvm_get_user_page_io(struct task_struct *tsk, struct mm_struct *mm, > npages = __get_user_pages(tsk, mm, addr, 1, flags, pagep, NULL, > &locked); > if (!locked) { > - VM_BUG_ON(npages != -EBUSY); > + VM_BUG_ON(npages); > > if (!pagep) > return 0; > -- > 2.1.0.rc2.206.gedb03e5 >