From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Nadav Amit <namit@cs.technion.ac.il>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: x2apic broadcast with physical mode does not work
Date: Wed, 1 Oct 2014 22:59:25 +0200 [thread overview]
Message-ID: <20141001205924.GF12083@potion.brq.redhat.com> (raw)
In-Reply-To: <8F4C8CF3-5C02-4617-BE22-63A6CD7FBC50@gmail.com>
2014-10-01 22:33+0300, Nadav Amit:
> I tried to implement your suggestion, but I don’t manage to make a nice and valid fix.
> The problem is that to determine the broadcast mode in the way you suggested, you need to have the lapic struct of one of the vCPUs with enabled apic.
> In kvm_irq_delivery_to_apic_fast, src may be NULL (if not issued by another CPU), or of a vCPU with disabled APIC. In such case I don’t know how to determine what is the broadcast message without looking at apic_map.
I see, sorry, apic_map is our best bet.
prev parent reply other threads:[~2014-10-01 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 18:15 [PATCH] KVM: x86: x2apic broadcast with physical mode does not work Nadav Amit
2014-09-29 18:19 ` [PATCH kvm-unit-tests] x86: Test physical x2apic broadcast ICR Nadav Amit
2014-10-01 0:09 ` [PATCH] KVM: x86: x2apic broadcast with physical mode does not work Radim Krčmář
2014-10-01 7:40 ` Nadav Amit
2014-10-01 13:35 ` Radim Krčmář
2014-10-01 19:33 ` Nadav Amit
2014-10-01 20:59 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001205924.GF12083@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=namit@cs.technion.ac.il \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox