From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH] KVM: x86: x2apic broadcast with physical mode does not
 work
Date: Wed, 1 Oct 2014 22:59:25 +0200
Message-ID: <20141001205924.GF12083@potion.brq.redhat.com>
References: <1412014558-16970-1-git-send-email-namit@cs.technion.ac.il>
 <20141001000956.GA7948@potion.redhat.com>
 <4A5CF035-AF20-465D-886F-449A85E8DB1D@gmail.com>
 <20141001133506.GA12083@potion.brq.redhat.com>
 <8F4C8CF3-5C02-4617-BE22-63A6CD7FBC50@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Nadav Amit <namit@cs.technion.ac.il>,
	Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
To: Nadav Amit <nadav.amit@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:35081 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751844AbaJAU7d (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 1 Oct 2014 16:59:33 -0400
Content-Disposition: inline
In-Reply-To: <8F4C8CF3-5C02-4617-BE22-63A6CD7FBC50@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2014-10-01 22:33+0300, Nadav Amit:
> I tried to implement your suggestion, but I don=E2=80=99t manage to m=
ake a nice and valid fix.
> The problem is that to determine the broadcast mode in the way you su=
ggested, you need to have the lapic struct of one of the vCPUs with ena=
bled apic.
> In kvm_irq_delivery_to_apic_fast, src may be NULL (if not issued by a=
nother CPU), or of a vCPU with disabled APIC. In such case I don=E2=80=99=
t know how to determine what is the broadcast message without looking a=
t apic_map.

I see, sorry, apic_map is our best bet.