From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Mario Smarduch <m.smarduch@samsung.com>
Cc: kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org,
pbonzini@redhat.com, agraf@suse.de, catalin.marinas@arm.com,
borntraeger@de.ibm.com, james.hogan@imgtec.com,
marc.zyngier@arm.com, xiaoguangrong@linux.vnet.ibm.com,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
kvm-ia64@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
steve.capper@arm.com, peter.maydell@linaro.org
Subject: Re: [PATCH v12 1/6] KVM: Add architecture-defined TLB flush support
Date: Thu, 30 Oct 2014 13:06:58 +0100 [thread overview]
Message-ID: <20141030130658.2b8f183e.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1414017251-5772-2-git-send-email-m.smarduch@samsung.com>
On Wed, 22 Oct 2014 15:34:06 -0700
Mario Smarduch <m.smarduch@samsung.com> wrote:
> This patch adds support for architecture implemented VM TLB flush, currently
> ARMv7 defines HAVE_KVM_ARCH_TLB_FLUSH_ALL. This leaves other architectures
> unaffected using the generic version. In subsequent patch ARMv7 defines
> HAVE_KVM_ARCH_TLB_FLUSH_ALL and it's own TLB flush interface.
Can you reword this a bit?
"Allow architectures to override the generic kvm_flush_remote_tlbs()
function via HAVE_KVM_ARCH_TLB_FLUSH_ALL. ARMv7 will need this to
provide its own TLB flush interface."
>
> Signed-off-by: Mario Smarduch <m.smarduch@samsung.com>
> ---
> virt/kvm/Kconfig | 3 +++
> virt/kvm/kvm_main.c | 2 ++
> 2 files changed, 5 insertions(+)
Providing an override for the special cases looks sane to me.
next prev parent reply other threads:[~2014-10-30 12:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 22:34 [PATCH v12 0/6] arm/KVM: dirty page logging support for ARMv7 (3.17.0-rc1) Mario Smarduch
2014-10-22 22:34 ` [PATCH v12 1/6] KVM: Add architecture-defined TLB flush support Mario Smarduch
2014-10-30 12:06 ` Cornelia Huck [this message]
2014-11-05 16:10 ` Paolo Bonzini
2014-10-22 22:34 ` [PATCH v12 2/6] KVM: Add generic support for dirty page logging Mario Smarduch
2014-10-30 12:14 ` Cornelia Huck
2014-10-30 19:19 ` Mario Smarduch
2014-11-03 3:01 ` Takuya Yoshikawa
2014-11-03 19:34 ` Mario Smarduch
2014-11-01 10:12 ` James Hogan
2014-11-03 18:44 ` Mario Smarduch
2014-11-05 16:09 ` Paolo Bonzini
2014-11-05 23:05 ` Mario Smarduch
2014-11-06 10:14 ` Paolo Bonzini
2014-11-06 18:07 ` Mario Smarduch
2014-10-22 22:34 ` [PATCH v12 3/6] arm: KVM: Add ARMv7 API to flush TLBs Mario Smarduch
2014-10-22 22:34 ` [PATCH v12 4/6] arm: KVM: Add initial dirty page locking infrastructure Mario Smarduch
2014-10-27 23:26 ` [PATCH v12 0/6] arm/KVM: dirty page logging support for ARMv7 (3.17.0-rc1) Wanpeng Li
2014-10-28 0:28 ` Mario Smarduch
2014-10-28 1:24 ` Wanpeng Li
2014-10-28 16:15 ` Mario Smarduch
2014-10-28 16:29 ` [PATCH v12 0/6] 2nd-request for review comments: " Mario Smarduch
2014-10-30 12:11 ` [PATCH v12 0/6] " Christian Borntraeger
2014-10-30 19:27 ` Mario Smarduch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030130658.2b8f183e.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=james.hogan@imgtec.com \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=m.smarduch@samsung.com \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=steve.capper@arm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox