From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH v13 3/7] KVM: x86: flush TLBs last before returning from KVM_GET_DIRTY_LOG Date: Fri, 7 Nov 2014 21:02:15 +0100 Message-ID: <20141107200215.GA23953@cbox> References: <1415320848-13813-1-git-send-email-m.smarduch@samsung.com> <1415320848-13813-4-git-send-email-m.smarduch@samsung.com> <545C7845.9010103@redhat.com> <545D2271.4090906@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Bonzini , james.hogan@imgtec.com, agraf@suse.de, marc.zyngier@arm.com, cornelia.huck@de.ibm.com, borntraeger@de.ibm.com, catalin.marinas@arm.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org, linux-arm-kernel@lists.infradead.org, steve.capper@arm.com, peter.maydell@linaro.org To: Mario Smarduch Return-path: Content-Disposition: inline In-Reply-To: <545D2271.4090906@samsung.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Fri, Nov 07, 2014 at 11:50:09AM -0800, Mario Smarduch wrote: > On 11/06/2014 11:44 PM, Paolo Bonzini wrote: > > > > > > On 07/11/2014 01:40, Mario Smarduch wrote: > >> In the next patches, we will move parts of x86's kvm_vm_ioctl_get_dirty_log > >> implementation to generic code; leave the arch-specific code at the end, > >> similar to the existing generic function kvm_get_dirty_log. > >> > >> Reviewed-by: Mario Smarduch > >> Signed-off-by: Paolo Bonzini > > > > You should have a "Signed-off-by: Mario Smarduch ..." here, and you > > should also add my authorship. You can do the latter with "git rebase > > -i", adding > > > > x git commit --amend -C HEAD --author 'Paolo Bonzini ' > > > > after this patch. If you're using a patch queue instead (quilt or > > similar) you can just edit the "From" line in the patch. > > > > I guess if you reply to the patch with just > > > > Signed-off-by: Mario Smarduch > > > > the ARM maintainers can do the above for you, if there's no need for > > a v14. > > > > I'll send an eighth patch to actually switch x86 to the new function. > > Again, the maintainers can apply it in the right place, but please > > include it yourself if you have to do a v14. > > > > Thanks, > > > > Paolo > > I kind of thought something was wrong :) Thanks for the explanation, > until I get the hang of it I'll defer to ARM maintainers. Maybe later > update SubmittingPatches documentation. > Since you're doing a respin (right?) then please get the authorship and signed-off-by's right for the next iteration. If you're having trouble with the git mangling to get it right, don't be afraid to reach out, here or on IRC. -Christoffer