From: Andrew Jones <drjones@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
kvm-devel <kvm@vger.kernel.org>
Subject: Re: KVM: x86: add module parameter to disable periodic kvmclock sync
Date: Thu, 13 Nov 2014 18:57:57 +0100 [thread overview]
Message-ID: <20141113175756.GC2958@hawk.usersys.redhat.com> (raw)
In-Reply-To: <5464EEBC.7080602@redhat.com>
On Thu, Nov 13, 2014 at 06:47:40PM +0100, Paolo Bonzini wrote:
>
>
> On 13/11/2014 18:46, Radim Krčmář wrote:
> > Yes, or add callbacks to sysfs writes that would schedule/cancel this
> > work. (But having a for_every_vm loop is quite ugly.)
> >
> > I'd be happy with a 'const kvmclock_periodic_sync'.
> > (Having useless timers is weird if we care about latencies.)
>
> I agree.
>
yeah, I guess Marcelo's thought was that users may turn it
off with sysfs, but once off, it'll never get to come back.
In that case the original patch is perfectly fine as is.
drew
next prev parent reply other threads:[~2014-11-13 17:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 2:44 KVM: x86: add module parameter to disable periodic kvmclock sync Marcelo Tosatti
2014-11-13 8:40 ` Andrew Jones
2014-11-13 10:44 ` Andrew Jones
2014-11-13 11:32 ` Andrew Jones
2014-11-13 17:46 ` Radim Krčmář
2014-11-13 17:47 ` Paolo Bonzini
2014-11-13 17:57 ` Andrew Jones [this message]
2014-11-13 18:24 ` Radim Krčmář
2014-11-14 18:51 ` Marcelo Tosatti
2014-11-13 14:14 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113175756.GC2958@hawk.usersys.redhat.com \
--to=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox