From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanpeng Li Subject: Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host Date: Tue, 25 Nov 2014 18:13:31 +0800 Message-ID: <20141125101331.GA28985@kernel> References: <1416847414-22253-1-git-send-email-pbonzini@redhat.com> Reply-To: Wanpeng Li Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, namit@cs.technion.ac.il, hpa@linux.intel.com To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <1416847414-22253-1-git-send-email-pbonzini@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Hi Paolo, On Mon, Nov 24, 2014 at 05:43:32PM +0100, Paolo Bonzini wrote: >The first patch ensures that XSAVES is not exposed in the guest until >we emulate MSR_IA32_XSS. The second exports XSAVE data in the correct >format. > >I tested these on a non-XSAVES system so they should not be completely >broken, but I need some help. I am not even sure which XSAVE states >are _not_ enabled, and thus compacted, in Linux. > >Note that these patches do not add support for XSAVES in the guest yet, >since MSR_IA32_XSS is not emulated. > >If they fix the bug Nadav reported, I'll add Reported-by and commit. I test this patchset w/ your "KVM: x86: export get_xsave_addr" patch on Skylake and guest hang during boot. The guest screen show "Probing EDD (edd=off to disable)... ok", and no more dump. Regards, Wanpeng Li > >Thanks, > >Paolo > >v1->v2: also adjust KVM_SET_XSAVE > >Paolo Bonzini (2): > kvm: x86: mask out XSAVES > KVM: x86: support XSAVES usage in the host > > arch/x86/kvm/cpuid.c | 11 ++++++- > arch/x86/kvm/x86.c | 87 +++++++++++++++++++++++++++++++++++++++++++----- > 2 files changed, 90 insertions(+), 8 deletions(-) > >-- >1.8.3.1