From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH RFC v2 07/12] dataplane: allow virtio-1 devices Date: Tue, 25 Nov 2014 19:01:41 +0100 Message-ID: <20141125190141.44a58471.cornelia.huck@de.ibm.com> References: <1416921863-16523-1-git-send-email-cornelia.huck@de.ibm.com> <1416921863-16523-8-git-send-email-cornelia.huck@de.ibm.com> <20141125185556.44e23979@bahia.local> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org, kvm@vger.kernel.org, thuth@linux.vnet.ibm.com, mst@redhat.com To: Greg Kurz Return-path: Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:51208 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbaKYSBs convert rfc822-to-8bit (ORCPT ); Tue, 25 Nov 2014 13:01:48 -0500 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Nov 2014 18:01:46 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4A96817D8045 for ; Tue, 25 Nov 2014 18:01:59 +0000 (GMT) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sAPI1hWj10879338 for ; Tue, 25 Nov 2014 18:01:43 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sAPI1hFP005209 for ; Tue, 25 Nov 2014 13:01:43 -0500 In-Reply-To: <20141125185556.44e23979@bahia.local> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 25 Nov 2014 18:55:56 +0100 Greg Kurz wrote: > On Tue, 25 Nov 2014 14:24:18 +0100 > Cornelia Huck wrote: >=20 > > Handle endianness conversion for virtio-1 virtqueues correctly. > >=20 > > Note that dataplane now needs to be built per-target. > >=20 > > Signed-off-by: Cornelia Huck > > --- >=20 > We still have the same error as in your previous post... >=20 > In file included from include/hw/virtio/dataplane/vring.h:23:0, > from include/hw/virtio/virtio-scsi.h:21, > from hw/virtio/virtio-pci.c:24: > include/hw/virtio/virtio-access.h: In function =E2=80=98virtio_access= _is_big_endian=E2=80=99: > include/hw/virtio/virtio-access.h:28:15: error: attempt to use poison= ed "TARGET_WORDS_BIGENDIAN" > #elif defined(TARGET_WORDS_BIGENDIAN) Grmpf, I thought I had fixed this. I'll do an update tomorrow. >=20 > Either build virtio-pci per-target or probably better move the target= tainted > accessors to another file. >=20 > > hw/block/dataplane/virtio-blk.c | 3 +- > > hw/scsi/virtio-scsi-dataplane.c | 2 +- > > hw/virtio/Makefile.objs | 2 +- > > hw/virtio/dataplane/Makefile.objs | 2 +- > > hw/virtio/dataplane/vring.c | 85 +++++++++++++++++++----= ------------ > > include/hw/virtio/dataplane/vring.h | 64 +++++++++++++++++++++++= +-- > > 6 files changed, 113 insertions(+), 45 deletions(-)