Re: Another Obsolete Fix me in trace.h?

Paolo Bonzini
2014-11-24T10:12:05Z

On 24/11/2014 05:36, nick wrote:
> Greetings Again Gleb and others,
> I am assuming in the code I am pasting below the fix me is obsolete now and I can remove it. :)
> Cheers Nick
> TP_printk("%s (0x%x)",
> __print_symbolic(__entry->exception, kvm_trace_sym_exc),
> /* FIXME: don't print error_code if not present */
> __entry->has_error ? __entry->error_code : 0)
> );
>

No, it's not obsolete, the idea is to print only

%s

instead of

%s (0x%x)

if __entry->has_error is false. I don't know the trace API well enough
to know if that is possible.

Paolo