Re: Another Obsolete Fix me in trace.h?

Jan Kiszka
2014-11-24T10:40:51Z

On 2014-11-24 11:12, Paolo Bonzini wrote:
> On 24/11/2014 05:36, nick wrote:
>> Greetings Again Gleb and others,
>> I am assuming in the code I am pasting below the fix me is obsolete now and I can remove it. :)
>> Cheers Nick
>> TP_printk("%s (0x%x)",
>> __print_symbolic(__entry->exception, kvm_trace_sym_exc),
>> /* FIXME: don't print error_code if not present */
>> __entry->has_error ? __entry->error_code : 0)
>> );
>>
>
> No, it's not obsolete, the idea is to print only
>
> %s
>
> instead of
>
> %s (0x%x)
>
> if __entry->has_error is false. I don't know the trace API well enough
> to know if that is possible.

Last time I ran across such a scenario, it was not feasible and
essentially required separate tracepoints. But maybe Steven knows a trick.

Jan

--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux