From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: Re: [PATCH RFC v3 11/12] virtio-net/virtio-blk: enable virtio 1.0
Date: Thu, 27 Nov 2014 11:34:20 +0100
Message-ID: <20141127113420.2eaaa82f.cornelia.huck@de.ibm.com>
References: <1417022923-1654-1-git-send-email-cornelia.huck@de.ibm.com>
	<1417022923-1654-12-git-send-email-cornelia.huck@de.ibm.com>
	<20141126185005.GA9549@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org,
	kvm@vger.kernel.org, rusty@rustcorp.com.au,
	thuth@linux.vnet.ibm.com
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:37663 "EHLO
	e06smtp11.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751761AbaK0Ke2 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 27 Nov 2014 05:34:28 -0500
Received: from /spool/local
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <cornelia.huck@de.ibm.com>;
	Thu, 27 Nov 2014 10:34:26 -0000
Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 677D32190056
	for <kvm@vger.kernel.org>; Thu, 27 Nov 2014 10:33:55 +0000 (GMT)
Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251])
	by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sARAYMTN15270038
	for <kvm@vger.kernel.org>; Thu, 27 Nov 2014 10:34:22 GMT
Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sARAYLIK028503
	for <kvm@vger.kernel.org>; Thu, 27 Nov 2014 03:34:22 -0700
In-Reply-To: <20141126185005.GA9549@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 26 Nov 2014 20:50:05 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Wed, Nov 26, 2014 at 06:28:42PM +0100, Cornelia Huck wrote:
> > virtio-net (non-vhost) and virtio-blk have everything in place to support
> > virtio 1.0: let's enable the feature bit for them.
> 
> Hmm I doubt that.
> At least not without more patches.
> 
> For block, scsi, wce and config-wce must be off, and
> it must support ANY_LAYOUT (which might be a bit more code).
> 
> For net, header size is different when mergeable bufs are off,
> and mac is read-only.

Yeah, I'll need to walk through the spec again, this was mainly to test
my changes.