[PATCH] [mm] trivial fixes to long lines and typo in comment

[PATCH] [mm] trivial fixes to long lines and typo in comment

[Zhihui Zhang]

Well, the subject line says it all.

Signed-off-by: Zhihui Zhang <zzhsuny@gmail.com>
---
 include/linux/mmzone.h | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index ffe66e3..cb668b7 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -966,7 +966,9 @@ static inline int zonelist_node_idx(struct zoneref *zoneref)
 }
 
 /**
- * next_zones_zonelist - Returns the next zone at or below highest_zoneidx within the allowed nodemask using a cursor within a zonelist as a starting point
+ * next_zones_zonelist - Returns the next zone at or below highest_zoneidx
+ *                       within the allowed nodemask using a cursor within
+ *                       a zonelist as a starting point
  * @z - The cursor used as a starting point for the search
  * @highest_zoneidx - The zone index of the highest zone to return
  * @nodes - An optional nodemask to filter the zonelist with
@@ -984,7 +986,8 @@ struct zoneref *next_zones_zonelist(struct zoneref *z,
 					struct zone **zone);
 
 /**
- * first_zones_zonelist - Returns the first zone at or below highest_zoneidx within the allowed nodemask in a zonelist
+ * first_zones_zonelist - Returns the first zone at or below highest_zoneidx
+ *                        within the allowed nodemask in a zonelist
  * @zonelist - The zonelist to search for a suitable zone
  * @highest_zoneidx - The zone index of the highest zone to return
  * @nodes - An optional nodemask to filter the zonelist with
@@ -1005,7 +1008,9 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist,
 }
 
 /**
- * for_each_zone_zonelist_nodemask - helper macro to iterate over valid zones in a zonelist at or below a given zone index and within a nodemask
+ * for_each_zone_zonelist_nodemask - helper macro to iterate over valid zones
+ *                                   in a zonelist at or below a given zone
+ *                                   index and within a nodemask
  * @zone - The current zone in the iterator
  * @z - The current pointer within zonelist->zones being iterated
  * @zlist - The zonelist being iterated
@@ -1021,7 +1026,8 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist,
 		z = next_zones_zonelist(++z, highidx, nodemask, &zone))	\
 
 /**
- * for_each_zone_zonelist - helper macro to iterate over valid zones in a zonelist at or below a given zone index
+ * for_each_zone_zonelist - helper macro to iterate over valid zones in a
+ *                          zonelist at or below a given zone index
  * @zone - The current zone in the iterator
  * @z - The current pointer within zonelist->zones being iterated
  * @zlist - The zonelist being iterated
@@ -1138,7 +1144,7 @@ extern unsigned long usemap_size(void);
 /*
  * We use the lower bits of the mem_map pointer to store
  * a little bit of information.  There should be at least
- * 3 bits here due to 32-bit alignment.
+ * 2 bits here due to 32-bit alignment.
  */
 #define	SECTION_MARKED_PRESENT	(1UL<<0)
 #define SECTION_HAS_MEM_MAP	(1UL<<1)
-- 
1.9.1

Re: [PATCH] [mm] trivial fixes to long lines and typo in comment

[Mel Gorman]

On Sat, Nov 29, 2014 at 10:46:59AM -0500, Zhihui Zhang wrote:
> Well, the subject line says it all.
> 

Why bother?

It adds almost nothing (one meaningful change) and git blame would no
longer points to the commit that actually modified that introduced or last
updated those comments.

-- 
Mel Gorman
SUSE Labs

Re: [PATCH] [mm] trivial fixes to long lines and typo in comment

[Jiri Kosina]

On Sat, 29 Nov 2014, Mel Gorman wrote:

> > Well, the subject line says it all.
> > 
> 
> Why bother?
> 
> It adds almost nothing (one meaningful change) and git blame would no
> longer points to the commit that actually modified that introduced or last
> updated those comments.

Agreed.

I am usually taking typo fixes through trivial.git, as they might 
potentially help someone who is grepping around the sources and hoping to 
actually find something :)

But just reformatting long lines in comments is just not worth it at all.

-- 
Jiri Kosina
SUSE Labs