From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH 2/7] KVM: arm: guest debug, define API headers Date: Sat, 29 Nov 2014 17:20:53 +0100 Message-ID: <20141129162053.GD23653@cbox> References: <1416931805-23223-1-git-send-email-alex.bennee@linaro.org> <1416931805-23223-3-git-send-email-alex.bennee@linaro.org> <87ppcaknpx.fsf@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Peter Maydell , kvm-devel , arm-mail-list , "kvmarm@lists.cs.columbia.edu" , Marc Zyngier , Alexander Graf , "J. Kiszka" , David Hildenbrand , Bharat Bhushan , bp@suse.de, Paolo Bonzini , Catalin Marinas , Will Deacon , open list To: Alex =?iso-8859-1?Q?Benn=E9e?= Return-path: Content-Disposition: inline In-Reply-To: <87ppcaknpx.fsf@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Nov 26, 2014 at 03:04:10PM +0000, Alex Benn=E9e wrote: >=20 > Peter Maydell writes: >=20 > > On 25 November 2014 at 16:10, Alex Benn=E9e wrote: > >> +/* Exit types which define why we did a debug exit */ > >> +#define KVM_DEBUG_EXIT_ERROR 0x0 > >> +#define KVM_DEBUG_EXIT_SINGLE_STEP 0x1 > >> +#define KVM_DEBUG_EXIT_SW_BKPT 0x2 > >> +#define KVM_DEBUG_EXIT_HW_BKPT 0x3 > >> +#define KVM_DEBUG_EXIT_HW_WTPT 0x4 > > > > The names of these imply that they're generic, but they're > > defined in an arch-specific header file... >=20 > Yeah, I think these will die and I'll just export the syndrome > information directly to QEMU. huh? -Christoffer