Re: [PATCH 9/9] kvm: vmx: add nested virtualization support for xsaves

Radim Krčmář
2014-12-04T18:08:07Z

2014-12-04 16:57+0100, Paolo Bonzini:
> From: Wanpeng Li <wanpeng.li@linux.intel.com>
>
> Add vmcs12 support for xsaves.
>
> Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---

Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>

> + case EXIT_REASON_XSAVES: case EXIT_REASON_XRSTORS:
> + /*
> + * This should never happen, since it is not possible to
> + * set XSS to a non-zero value---neither in L1 nor in L2.
> + * If if it were, XSS would have to be checked against
> + * the XSS exit bitmap in vmcs12.
> + */

We could WARN then.

> + return nested_cpu_has2(vmcs12, SECONDARY_EXEC_XSAVES);
> default:
> return 1;
> }