From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: Stupid Xen vs KVM question
Date: Fri, 5 Dec 2014 11:09:08 -0500
Message-ID: <20141205160908.GB472@laptop.dumpdata.com>
References: <CALCETrUQfzqtVzE8GV2yRkzyiWzVfzL-FL8FzTRXJQiFSXhk+w@mail.gmail.com>
 <20141205022420.GA27661@konrad-lan.dumpdata.com>
 <54815EF2.4030808@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andy Lutomirski <luto@amacapital.net>,
	kvm list <kvm@vger.kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from aserp1040.oracle.com ([141.146.126.69]:35587 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750907AbaLEQJa (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 5 Dec 2014 11:09:30 -0500
Content-Disposition: inline
In-Reply-To: <54815EF2.4030808@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Dec 05, 2014 at 08:29:54AM +0100, Paolo Bonzini wrote:
> 
> 
> On 05/12/2014 03:24, Konrad Rzeszutek Wilk wrote:
> > We could do a simple thing - which is that the paravirt_enabled
> > could have the value 1 for Xen and 2 for KVM. The assembler logic
> > would be inverted and just check for 1. I am not going to attempt
> > to write the assembler code :-)
> 
> Wouldn't Xen HVM also want to be 2?

Oddly enough it was never set!

Looking at where the paravit_enabled() macro is used, on KVM it could
be just set to zero.
> 
> Paolo