From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Eugene Korenevsky <ekorenevsky@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>,
kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@web.de>,
Wincy Van <fanwenyi0529@gmail.com>
Subject: Re: [PATCH] KVM: x86: nVMX: support for MSR loading/storing
Date: Tue, 9 Dec 2014 22:59:08 +0100 [thread overview]
Message-ID: <20141209215907.GA31084@potion.brq.redhat.com> (raw)
In-Reply-To: <20141209211810.GA17879@gnote>
2014-12-10 00:18+0300, Eugene Korenevsky:
> +static bool vmx_load_msr_entry_verify(struct kvm_vcpu *vcpu,
> + struct vmx_msr_entry *e)
[...]
> + /* x2APIC MSR accesses are not allowed */
> + if (apic_x2apic_mode(vcpu->arch.apic) && (e->index >> 24) == 0x800)
> + return false;
GCC doesn't warn that "((u32)e->index >> 24) == 0x800" is always false?
I think SDM says '(e->index >> 8) == 0x8'.
next prev parent reply other threads:[~2014-12-09 21:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 21:18 [PATCH] KVM: x86: nVMX: support for MSR loading/storing Eugene Korenevsky
2014-12-09 21:59 ` Radim Krčmář [this message]
2014-12-10 9:08 ` Eugene Korenevsky
2014-12-10 9:13 ` Eugene Korenevsky
2014-12-10 9:02 ` Wanpeng Li
-- strict thread matches above, loose matches on Subject: below --
2014-12-09 0:41 Eugene Korenevsky
2014-12-09 14:05 ` Bandan Das
2014-12-09 21:12 ` Eugene Korenevsky
2014-12-10 2:00 ` Wincy Van
2014-12-10 9:07 ` Eugene Korenevsky
2014-12-10 9:01 ` Wanpeng Li
2014-12-10 9:35 ` Wincy Van
2014-12-10 9:44 ` Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209215907.GA31084@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=bsd@redhat.com \
--cc=ekorenevsky@gmail.com \
--cc=fanwenyi0529@gmail.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox