From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH] KVM: add KVM_CAP_VMX_APICV to advertise hardware apic-v
 support
Date: Thu, 11 Dec 2014 14:08:08 +0100
Message-ID: <20141211130807.GA18311@potion.brq.redhat.com>
References: <1418285221-14256-1-git-send-email-zhang.zhanghailiang@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, gleb@kernel.org, pbonzini@redhat.com,
	peter.huangpeng@huawei.com
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:41644 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750843AbaLKNIV (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 11 Dec 2014 08:08:21 -0500
Content-Disposition: inline
In-Reply-To: <1418285221-14256-1-git-send-email-zhang.zhanghailiang@huawei.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2014-12-11 16:07+0800, zhanghailiang:
> User space (i.e. QEMU) should be able to check whether KVM
> supports apic-v. User space will use this to decide whether enable
> emulated MSR-based APIC (i.e. hyperv-vapic).

Userspace is able to look at enable_apicv module parameter.
(This decision probably belongs to controls above QEMU.)

Anyway, I haven't thought much about it, so to the patch itself:
- KVM_CAP_VMX_APICV isn't a good name for a capability that doesn't
  require VMX.
- The detection depends on irqchip_in_kernel(), which is awkward.