public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, Luiz Capitulino <lcapitulino@redhat.com>,
	Rik van Riel <riel@redhat.com>, Radim Krcmar <rkrcmar@redhat.com>
Subject: Re: [patch 2/2] KVM: x86: add option to advance tscdeadline hrtimer expiration
Date: Thu, 11 Dec 2014 18:58:03 -0200	[thread overview]
Message-ID: <20141211205803.GA22650@amt.cnet> (raw)
In-Reply-To: <548A0324.7070504@amacapital.net>

On Thu, Dec 11, 2014 at 12:48:36PM -0800, Andy Lutomirski wrote:
> On 12/10/2014 07:07 PM, Marcelo Tosatti wrote:
> > On Thu, Dec 11, 2014 at 12:37:57AM +0100, Paolo Bonzini wrote:
> >>
> >>
> >> On 10/12/2014 21:57, Marcelo Tosatti wrote:
> >>> For the hrtimer which emulates the tscdeadline timer in the guest,
> >>> add an option to advance expiration, and busy spin on VM-entry waiting
> >>> for the actual expiration time to elapse.
> >>>
> >>> This allows achieving low latencies in cyclictest (or any scenario 
> >>> which requires strict timing regarding timer expiration).
> >>>
> >>> Reduces cyclictest avg latency by 50%.
> >>>
> >>> Note: this option requires tuning to find the appropriate value 
> >>> for a particular hardware/guest combination. One method is to measure the 
> >>> average delay between apic_timer_fn and VM-entry. 
> >>> Another method is to start with 1000ns, and increase the value
> >>> in say 500ns increments until avg cyclictest numbers stop decreasing.
> >>
> >> What values are you using in practice for the parameter?
> > 
> > 7us.
> 
> 
> It takes 7us to get from TSC deadline expiration to the *start* of
> vmresume?  That seems rather extreme.
> 
> Is it possible that almost all of that latency is from deadline
> expiration to C-state exit?  If so, can we teach the timer code to wake
> up early to account for that?  We're supposed to know our idle exit
> latency these days.

7us includes: 

idle thread wakeup
idle schedout
ksoftirqd schedin
ksoftirqd schedout
qemu schedin
vm-entry

C-states are disabled of course.


  reply	other threads:[~2014-12-11 20:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10 20:57 [patch 0/2] KVM: add option to advance tscdeadline hrtimer expiration (v3) Marcelo Tosatti
2014-12-10 20:57 ` [patch 1/2] KVM: x86: add method to test PIR bitmap vector Marcelo Tosatti
2014-12-10 20:57 ` [patch 2/2] KVM: x86: add option to advance tscdeadline hrtimer expiration Marcelo Tosatti
2014-12-10 23:37   ` Paolo Bonzini
2014-12-11  3:07     ` Marcelo Tosatti
2014-12-11 18:58       ` Paolo Bonzini
2014-12-11 20:48       ` Andy Lutomirski
2014-12-11 20:58         ` Marcelo Tosatti [this message]
2014-12-11 21:07           ` Andy Lutomirski
2014-12-11 21:37             ` Rik van Riel
2014-12-11 21:10         ` Paolo Bonzini
2014-12-11 21:16           ` Andy Lutomirski
2014-12-11 21:27             ` Marcelo Tosatti
2014-12-11 21:29               ` Marcelo Tosatti
2014-12-12 18:35   ` Radim Krcmar
  -- strict thread matches above, loose matches on Subject: below --
2014-12-10 17:06 [patch 0/2] KVM: add option to advance tscdeadline hrtimer expiration (v2) Marcelo Tosatti
2014-12-10 17:06 ` [patch 2/2] KVM: x86: add option to advance tscdeadline hrtimer expiration Marcelo Tosatti
2014-12-10 17:11   ` Rik van Riel
2014-12-10 16:53 [patch 0/2] KVM: " Marcelo.Tosatti
2014-12-10 16:53 ` [patch 2/2] KVM: x86: " Marcelo.Tosatti
2014-12-10 17:08   ` Paolo Bonzini
2014-12-10 17:34     ` Marcelo Tosatti
2014-12-10 17:53       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141211205803.GA22650@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lcapitulino@redhat.com \
    --cc=luto@amacapital.net \
    --cc=pbonzini@redhat.com \
    --cc=riel@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox