* [PATCH] kvm-unit-tests: minor: remove unused variable
@ 2014-12-12 19:54 Eugene Korenevsky
2014-12-15 15:01 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Eugene Korenevsky @ 2014-12-12 19:54 UTC (permalink / raw)
To: kvm; +Cc: Paolo Bonzini
Remove unused variable to get rid of compiler warning.
And remove commented out code (it can always be restored
from git logs).
Signed-off-by: Eugene Korenevsky <ekorenevsky@gmail.com>
---
x86/vmx_tests.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index 184fafc..0daaacf 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -1439,12 +1439,10 @@ static int dbgctls_init(struct vmcs *vmcs)
static void dbgctls_main(void)
{
- u64 dr7, debugctl;
+ u64 dr7;
asm volatile("mov %%dr7,%0" : "=r" (dr7));
- debugctl = rdmsr(MSR_IA32_DEBUGCTLMSR);
- /* Commented out: KVM does not support DEBUGCTL so far */
- report("Load debug controls", dr7 == 0x404 /* && debugctl == 0x2 */);
+ report("Load debug controls", dr7 == 0x404);
dr7 = 0x408;
asm volatile("mov %0,%%dr7" : : "r" (dr7));
@@ -1463,9 +1461,7 @@ static void dbgctls_main(void)
vmcall();
asm volatile("mov %%dr7,%0" : "=r" (dr7));
- debugctl = rdmsr(MSR_IA32_DEBUGCTLMSR);
- /* Commented out: KVM does not support DEBUGCTL so far */
- report("Guest=host debug controls", dr7 == 0x402 /* && debugctl == 0x1 */);
+ report("Guest=host debug controls", dr7 == 0x402);
dr7 = 0x408;
asm volatile("mov %0,%%dr7" : : "r" (dr7));
--
2.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm-unit-tests: minor: remove unused variable
2014-12-12 19:54 [PATCH] kvm-unit-tests: minor: remove unused variable Eugene Korenevsky
@ 2014-12-15 15:01 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2014-12-15 15:01 UTC (permalink / raw)
To: Eugene Korenevsky, kvm
On 12/12/2014 20:54, Eugene Korenevsky wrote:
> Remove unused variable to get rid of compiler warning.
> And remove commented out code (it can always be restored
> from git logs).
This is also specifying that the behavior is incorrect. It should be
changed to an XFAIL instead.
Paolo
> Signed-off-by: Eugene Korenevsky <ekorenevsky@gmail.com>
> ---
> x86/vmx_tests.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
> index 184fafc..0daaacf 100644
> --- a/x86/vmx_tests.c
> +++ b/x86/vmx_tests.c
> @@ -1439,12 +1439,10 @@ static int dbgctls_init(struct vmcs *vmcs)
>
> static void dbgctls_main(void)
> {
> - u64 dr7, debugctl;
> + u64 dr7;
>
> asm volatile("mov %%dr7,%0" : "=r" (dr7));
> - debugctl = rdmsr(MSR_IA32_DEBUGCTLMSR);
> - /* Commented out: KVM does not support DEBUGCTL so far */
> - report("Load debug controls", dr7 == 0x404 /* && debugctl == 0x2 */);
> + report("Load debug controls", dr7 == 0x404);
>
> dr7 = 0x408;
> asm volatile("mov %0,%%dr7" : : "r" (dr7));
> @@ -1463,9 +1461,7 @@ static void dbgctls_main(void)
> vmcall();
>
> asm volatile("mov %%dr7,%0" : "=r" (dr7));
> - debugctl = rdmsr(MSR_IA32_DEBUGCTLMSR);
> - /* Commented out: KVM does not support DEBUGCTL so far */
> - report("Guest=host debug controls", dr7 == 0x402 /* && debugctl == 0x1 */);
> + report("Guest=host debug controls", dr7 == 0x402);
>
> dr7 = 0x408;
> asm volatile("mov %0,%%dr7" : : "r" (dr7));
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-15 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-12 19:54 [PATCH] kvm-unit-tests: minor: remove unused variable Eugene Korenevsky
2014-12-15 15:01 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).