Re: [RFC 2/2] x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader

Paolo Bonzini
2015-01-06T12:01:09Z

On 06/01/2015 09:42, Paolo Bonzini wrote:
> > > Still confused. So we can freeze all vCPUs in the host, then update
> > > pvti 1, then resume vCPU 1, then update pvti 0? In that case, we have
> > > a problem, because vCPU 1 can observe pvti 0 mid-update, and KVM
> > > doesn't increment the version pre-update, and we can return completely
> > > bogus results.
> > Yes.
> But then the getcpu test would fail (1->0). Even if you have an ABA
> situation (1->0->1), it's okay because the pvti that is fetched is the
> one returned by the first getcpu.

... this case of partial update of pvti, which is caught by the version
field, if of course different from the other (extremely unlikely) that
Andy pointed out. That is when the getcpus are done on the same vCPU,
but the rdtsc is another.

That one can be fixed by rdtscp, like

do {
// get a consistent (pvti, v, tsc) tuple
do {
cpu = get_cpu();
pvti = get_pvti(cpu);
v = pvti->version & ~1;
// also acts as rmb();
rdtsc_barrier();
tsc = rdtscp(&cpu1);
// control dependency, no need for rdtsc_barrier?
} while(cpu != cpu1);

// ... compute nanoseconds from pvti and tsc ...
rmb();
} while(v != pvti->version);