From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH] arm64: KVM: Fix HCR setting for 32bit guests Date: Wed, 7 Jan 2015 15:17:36 +0100 Message-ID: <20150107141736.GH21092@cbox> References: <1420627503-25183-1-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org To: Marc Zyngier Return-path: Content-Disposition: inline In-Reply-To: <1420627503-25183-1-git-send-email-marc.zyngier@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: kvm.vger.kernel.org On Wed, Jan 07, 2015 at 10:45:03AM +0000, Marc Zyngier wrote: > Commit b856a59141b1 (arm/arm64: KVM: Reset the HCR on each vcpu > when resetting the vcpu) moved the init of the HCR register to > happen later in the init of a vcpu, but left out the fixup > done in kvm_reset_vcpu when preparing for a 32bit guest. > > As a result, the 32bit guest is run as a 64bit guest, but the > rest of the kernel still manages it as a 32bit. Fun follows. > > Moving the fixup to vcpu_reset_hcr solves the problem for good. > > Signed-off-by: Marc Zyngier Whoops, thanks for the fix. Acked-by: Christoffer Dall