Re: [RFC 0/2] x86, vdso, pvclock: Cleanups and speedups

Andy Lutomirski
2014-12-23T08:16:55Z

On Mon, Dec 22, 2014 at 11:21 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 23/12/2014 01:39, Andy Lutomirski wrote:
>> This is a dramatic simplification and speedup of the vdso pvclock read
>> code. Is it correct?
>>
>> Andy Lutomirski (2):
>> x86, vdso: Use asm volatile in __getcpu
>> x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader
>
> Patch 1 is ok,
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Any thoughts as to whether it should be tagged for stable? I haven't
looked closely enough at the old pvclock code or the generated code to
have much of an opinion there. It'll be a big speedup for non-pvclock
users at least.

--Andy

>
> For patch 2 I will defer to Marcelo and Glauber (and the Xen folks).
>
> Paolo

--
Andy Lutomirski
AMA Capital Management, LLC