From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Nicholas A. Bellinger" <nab@daterainc.com>
Cc: target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
kvm-devel <kvm@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Nicholas Bellinger <nab@linux-iscsi.org>
Subject: Re: [PATCH-v2 01/11] lib/iovec: Add memcpy_fromiovec_out library function
Date: Mon, 2 Feb 2015 04:44:12 +0000 [thread overview]
Message-ID: <20150202044412.GS29656@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1422849994-3419-2-git-send-email-nab@daterainc.com>
On Mon, Feb 02, 2015 at 04:06:24AM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
>
> This patch adds a new memcpy_fromiovec_out() library function which modifies
> the passed *iov following memcpy_fromiovec(), but also returns the next current
> iovec pointer via **iov_out.
>
> This is useful for vhost ANY_LAYOUT support when guests are allowed to generate
> incoming virtio request headers combined with subsequent SGL payloads into a
> single iovec.
Please, don't. Just use copy_from_iter(); you are open-coding an uglier
variant of such.
next prev parent reply other threads:[~2015-02-02 4:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 4:06 [PATCH-v2 00/11] vhost/scsi: Add ANY_LAYOUT + VERSION_1 support Nicholas A. Bellinger
2015-02-02 4:06 ` [PATCH-v2 01/11] lib/iovec: Add memcpy_fromiovec_out library function Nicholas A. Bellinger
2015-02-02 4:44 ` Al Viro [this message]
2015-02-02 4:47 ` Al Viro
2015-02-02 4:06 ` [PATCH-v2 02/11] vhost/scsi: Convert completion path to use memcpy_toiovecend Nicholas A. Bellinger
2015-02-02 4:06 ` [PATCH-v2 03/11] vhost/scsi: Fix incorrect early vhost_scsi_handle_vq failures Nicholas A. Bellinger
2015-02-02 4:06 ` [PATCH-v2 04/11] vhost/scsi: Change vhost_scsi_map_to_sgl to accept iov ptr + len Nicholas A. Bellinger
2015-02-02 4:06 ` [PATCH-v2 05/11] vhost/scsi: Add ANY_LAYOUT iov -> sgl mapping prerequisites Nicholas A. Bellinger
2015-02-02 4:06 ` [PATCH-v2 06/11] vhost/scsi: Add ANY_LAYOUT vhost_skip_iovec_bytes helper Nicholas A. Bellinger
2015-02-02 4:06 ` [PATCH-v2 07/11] vhost/scsi: Add ANY_LAYOUT vhost_virtqueue callback Nicholas A. Bellinger
2015-02-02 4:06 ` [PATCH-v2 08/11] vhost/scsi: Set VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits Nicholas A. Bellinger
2015-02-02 4:06 ` [PATCH-v2 09/11] vhost/scsi: Drop legacy pre virtio v1.0 !ANY_LAYOUT logic Nicholas A. Bellinger
2015-02-02 4:06 ` [PATCH-v2 10/11] vhost/scsi: Drop left-over scsi_tcq.h include Nicholas A. Bellinger
2015-02-02 4:06 ` [PATCH-v2 11/11] vhost/scsi: Global tcm_vhost -> vhost_scsi rename Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202044412.GS29656@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=kvm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nab@daterainc.com \
--cc=nab@linux-iscsi.org \
--cc=pbonzini@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox