From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH 5/6] KVM: x86: Add new dirty logging kvm_x86_ops for PML Date: Thu, 5 Feb 2015 15:52:49 +0100 Message-ID: <20150205145248.GA14367@potion.redhat.com> References: <1422413668-3509-1-git-send-email-kai.huang@linux.intel.com> <1422413668-3509-6-git-send-email-kai.huang@linux.intel.com> <20150203155302.GE19731@potion.redhat.com> <54D30DBD.2020300@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: pbonzini@redhat.com, gleb@kernel.org, linux@arm.linux.org.uk, kvm@vger.kernel.org To: Kai Huang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58534 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753475AbbBEOxD (ORCPT ); Thu, 5 Feb 2015 09:53:03 -0500 Content-Disposition: inline In-Reply-To: <54D30DBD.2020300@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: 2015-02-05 14:29+0800, Kai Huang: > >>+ /* Still write protect RO slot */ > >>+ if (new->flags & KVM_MEM_READONLY) { > >>+ kvm_mmu_slot_remove_write_access(kvm, new); > >We didn't write protect RO slots before, does this patch depend on it? > No PML doesn't depend on it to work. It's suggested by Paolo. Thanks, it would have deserved a separate patch, IMO.