From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Gleb Natapov <gleb@kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: Reason for extra struct kvm_run parameter in MMIO handling?
Date: Mon, 9 Feb 2015 17:21:54 +0100 [thread overview]
Message-ID: <20150209162154.GA1804@potion.brq.redhat.com> (raw)
In-Reply-To: <54D4FA45.1000103@arm.com>
2015-02-06 17:30+0000, Andre Przywara:
> As kvm_run is a member of kvm_vcpu, the vcpu alone should be sufficient,
> right?
Yes.
> Also I see the very top of the call chain is effectively:
> kvm_arch_vcpu_ioctl_run(vcpu, vcpu->run);
:(
> So is that just legacy code still lingering around from the dawn of time
> and nobody dared to rework this or is there a particular reason for
> doing so?
Probably laziness in 9a2bb7f486dc639a1cf2ad803bf2227f0dc0809d.
> I am asking because I lack the kvm_run pointer in the MMIO handler, so I
> just use vcpu->run and I wonder if there are potential issues in doing so.
We do it at few places already, so there, hopefully, is no problem.
next prev parent reply other threads:[~2015-02-09 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 17:30 Reason for extra struct kvm_run parameter in MMIO handling? Andre Przywara
2015-02-09 16:21 ` Radim Krčmář [this message]
2015-02-09 16:26 ` Paolo Bonzini
2015-02-09 17:22 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209162154.GA1804@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=andre.przywara@arm.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).