Re: [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

Michael Mueller
2015-02-20T16:12:49Z

On Fri, 20 Feb 2015 08:02:42 -0800
Richard Henderson <rth@twiddle.net> wrote:

> > +/**
> > + * s390_test_facility - test if given facility bit is set facility list
> > + * of given cpu class
> > + * @class: address of cpu class to test
> > + * @nr: bit number to test
> > + *
> > + * Returns: true in case it is set
> > + * false in case it is not set
> > + */
> > +bool s390_test_facility(S390CPUClass *cc, unsigned long nr)
> > +{
> > + if (cc) {
> > + return test_facility(nr, cc->fac_list) ? true : false;
> > + }
> > + return false;
> > +}
>
> Where do you see this being used?

Good spot, it's not being used yet. It's planned to be used with a patch that implements zPCI
related instructions on QEMU side. Maybe you have seen the discussion from Frank Blaschka in this
e-mail list in regard to that.

Michael