From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2] KVM: SVM: fix interrupt injection (apic->isr_count always 0) Date: Mon, 2 Mar 2015 19:04:58 -0300 Message-ID: <20150302220457.GA3055@amt.cnet> References: <1425051158-32472-1-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Borislav Petkov , Tiejun Chen To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Content-Disposition: inline In-Reply-To: <1425051158-32472-1-git-send-email-rkrcmar@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Fri, Feb 27, 2015 at 04:32:38PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: > In commit b4eef9b36db4, we started to use hwapic_isr_update() !=3D NU= LL > instead of kvm_apic_vid_enabled(vcpu->kvm). This didn't work because > SVM had it defined and "apicv" path in apic_{set,clear}_isr() does no= t > change apic->isr_count, because it should always be 1. The initial > value of apic->isr_count was based on kvm_apic_vid_enabled(vcpu->kvm)= , > which is always 0 for SVM, so KVM could have injected interrupts when= it > shouldn't. >=20 > Fix it by implicitly setting SVM's hwapic_isr_update to NULL and make= the > initial isr_count depend on hwapic_isr_update() for good measure. >=20 > Fixes: b4eef9b36db4 ("kvm: x86: vmx: NULL out hwapic_isr_update() in = case of !enable_apicv") > Reported-and-tested-by: Borislav Petkov > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > --- > v2: set hwapic_isr_update to NULL implicitly [Paolo] >=20 > arch/x86/kvm/lapic.c | 4 ++-- > arch/x86/kvm/svm.c | 6 ------ > 2 files changed, 2 insertions(+), 8 deletions(-) Applied, thanks.