From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH v3] x86: svm: use kvm_fast_pio_in()
Date: Tue, 3 Mar 2015 21:44:46 +0100
Message-ID: <20150303204445.GC2494@potion.brq.redhat.com>
References: <20150302210202.2951.56810.stgit@joelvmguard2.amd.com>
 <20150303164431.GD25123@potion.brq.redhat.com>
 <54F61388.6090002@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Gleb Natapov <gleb@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
	David Kaplan <David.Kaplan@amd.com>,
	Joerg Roedel <joro@8bytes.org>, linux-kernel@vger.kernel.org,
	Borislav Petkov <bp@alien8.de>
To: Joel Schopp <joel.schopp@amd.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <54F61388.6090002@amd.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

2015-03-03 14:03-0600, Joel Schopp:
> On 03/03/2015 10:44 AM, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
> > 2015-03-02 15:02-0600, Joel Schopp:
> >> +	int ret =3D emulator_pio_in_emulated(&vcpu->arch.emulate_ctxt, s=
ize,
> >> +					   port, &val, 1);
> > Btw. does this return 1 in some scenario?
> If a function returns a value it is always a good idea to check it an=
d
> act appropriately.  That said...
> emulator_pio_in_emulated will return 1 if emulator_pio_in_out returns=
 1

Ah, I have completely forgotten, thanks!