From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH stable 3.10, 3.12, 3.14] MIPS: Export FP functions used by lose_fpu(1) for KVM Date: Fri, 6 Mar 2015 08:22:49 -0800 Message-ID: <20150306162249.GA28962@roeck-us.net> References: <54F7BE2E.8070708@roeck-us.net> <1425571724-9480-1-git-send-email-james.hogan@imgtec.com> <20150306063034.GA6914@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: James Hogan , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, satoru.takeuchi@gmail.com, shuah.kh@samsung.com, stable@vger.kernel.org, linux-mips@linux-mips.org, Paolo Bonzini , Ralf Baechle , Paul Burton , Gleb Natapov , kvm@vger.kernel.org To: Greg Kroah-Hartman Return-path: Content-Disposition: inline In-Reply-To: <20150306063034.GA6914@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Mar 05, 2015 at 10:30:34PM -0800, Greg Kroah-Hartman wrote: > On Thu, Mar 05, 2015 at 04:08:44PM +0000, James Hogan wrote: > > [ Upstream commit 3ce465e04bfd8de9956d515d6e9587faac3375dc ] > > > > Export the _save_fp asm function used by the lose_fpu(1) macro to GPL > > modules so that KVM can make use of it when it is built as a module. > > > > This fixes the following build error when CONFIG_KVM=m due to commit > > f798217dfd03 ("KVM: MIPS: Don't leak FPU/DSP to guest"): > > > > ERROR: "_save_fp" [arch/mips/kvm/kvm.ko] undefined! > > > > Signed-off-by: James Hogan > > Fixes: f798217dfd03 (KVM: MIPS: Don't leak FPU/DSP to guest) > > Cc: Paolo Bonzini > > Cc: Ralf Baechle > > Cc: Paul Burton > > Cc: Gleb Natapov > > Cc: kvm@vger.kernel.org > > Cc: linux-mips@linux-mips.org > > Cc: # 3.10...3.15 > > Patchwork: https://patchwork.linux-mips.org/patch/9260/ > > Signed-off-by: Ralf Baechle > > [james.hogan@imgtec.com: Only export when CPU_R4K_FPU=y prior to v3.16, > > so as not to break the Octeon build which excludes FPU support. KVM > > depends on MIPS32r2 anyway.] > > Signed-off-by: James Hogan > > --- > > Appologies for the previous cavium_octeon_defconfig link breakage. > > Octeon has the symbol since 3.16, but not before. This backport should > > do the trick for stable 3.10, 3.12, and 3.14. Build tested with > > cavium_octeon_defconfig and malta_kvm_defconfig on those stable > > branches. > > --- > > arch/mips/kernel/mips_ksyms.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > Now fixed up, thanks. > My auto-builders still fail to build cavium_octeon_defconfig for 3.10 and 3.14, and as far as I can see they picked up no changes. Did you push the changes into the stable queue repository ? Thanks, Guenter