From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Joel Schopp <joel.schopp@amd.com>, Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, David Kaplan <David.Kaplan@amd.com>,
Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] x86: svm: make wbinvd faster
Date: Tue, 10 Mar 2015 12:01:31 +0100 [thread overview]
Message-ID: <20150310110131.GA12854@potion.brq.redhat.com> (raw)
In-Reply-To: <20150309232846.GB12125@amt.cnet>
2015-03-09 20:28-0300, Marcelo Tosatti:
> On Fri, Feb 27, 2015 at 06:19:18PM -0600, Joel Schopp wrote:
> > From: David Kaplan <David.Kaplan@amd.com>
> > No need to re-decode WBINVD since we know what it is from the intercept.
> >
> > Signed-off-by: David Kaplan <David.Kaplan@amd.com>
> > [extracted from larger unlrelated patch, forward ported, tested]
> > Signed-off-by: Joel Schopp <joel.schopp@amd.com>
>
> Can't you disable the intercept if need_emulate_wbinvd(vcpu) == false?
I don't think we want to: it should be faster to intercept and ignore
than to invalidate all caches. The exit doesn't affect other physical
cores and costs just about 10(?) L3 cache misses.
next prev parent reply other threads:[~2015-03-10 11:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 0:19 [PATCH] x86: svm: make wbinvd faster Joel Schopp
2015-03-02 2:29 ` Bandan Das
2015-03-02 13:59 ` Radim Krčmář
2015-03-02 15:25 ` Bandan Das
2015-03-02 16:03 ` Radim Krčmář
2015-03-02 16:58 ` Joel Schopp
2015-03-02 14:09 ` Radim Krčmář
2015-03-09 23:28 ` Marcelo Tosatti
2015-03-10 11:01 ` Radim Krčmář [this message]
2015-03-10 22:37 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310110131.GA12854@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=David.Kaplan@amd.com \
--cc=bp@alien8.de \
--cc=gleb@kernel.org \
--cc=joel.schopp@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox