From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] x86: svm: make wbinvd faster
Date: Tue, 10 Mar 2015 19:37:13 -0300
Message-ID: <20150310223713.GA17773@amt.cnet>
References: <20150228001917.15247.41063.stgit@joelvmguard2.amd.com>
 <20150309232846.GB12125@amt.cnet>
 <20150310110131.GA12854@potion.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Joel Schopp <joel.schopp@amd.com>, Gleb Natapov <gleb@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
	David Kaplan <David.Kaplan@amd.com>,
	Joerg Roedel <joro@8bytes.org>, linux-kernel@vger.kernel.org,
	Borislav Petkov <bp@alien8.de>
To: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20150310110131.GA12854@potion.brq.redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Tue, Mar 10, 2015 at 12:01:31PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 w=
rote:
> 2015-03-09 20:28-0300, Marcelo Tosatti:
> > On Fri, Feb 27, 2015 at 06:19:18PM -0600, Joel Schopp wrote:
> > > From: David Kaplan <David.Kaplan@amd.com>
> > > No need to re-decode WBINVD since we know what it is from the int=
ercept.
> > >=20
> > > Signed-off-by: David Kaplan <David.Kaplan@amd.com>
> > > [extracted from larger unlrelated patch, forward ported, tested]
> > > Signed-off-by: Joel Schopp <joel.schopp@amd.com>
> >=20
> > Can't you disable the intercept if need_emulate_wbinvd(vcpu) =3D=3D=
 false?=20
>=20
> I don't think we want to:  it should be faster to intercept and ignor=
e
> than to invalidate all caches.  The exit doesn't affect other physica=
l
> cores and costs just about 10(?) L3 cache misses.

Yes, right.