Re: [PATCH 2/2] drivers/vfio: Support EEH error injection

David Gibson
2015-03-12T01:47:51Z

[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]

On Wed, Mar 11, 2015 at 05:34:11PM +1100, Gavin Shan wrote:
> The patch adds one more EEH sub-command (VFIO_EEH_PE_INJECT_ERR)
> to inject the specified EEH error, which is represented by
> (struct vfio_eeh_pe_err), to the indicated PE for testing purpose.
>
> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
> ---
> Documentation/vfio.txt | 47 ++++++++++++++++++++++++++++++-------------
> drivers/vfio/vfio_spapr_eeh.c | 14 +++++++++++++
> include/uapi/linux/vfio.h | 34 ++++++++++++++++++++++++++++++-
> 3 files changed, 80 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/vfio.txt b/Documentation/vfio.txt
> index 96978ec..2e7f736 100644
> --- a/Documentation/vfio.txt
> +++ b/Documentation/vfio.txt
> @@ -328,7 +328,13 @@ So 4 additional ioctls have been added:
>
> The code flow from the example above should be slightly changed:
>
> - struct vfio_eeh_pe_op pe_op = { .argsz = sizeof(pe_op), .flags = 0 };
> + struct vfio_eeh_pe_op *pe_op;
> + struct vfio_eeh_pe_err *pe_err;
> +
> + pe_op = malloc(sizeof(*pe_op) + sizeof(*pe_err));
> + pe_err = (void *)pe_op + sizeof(*pe_op);
> + pe_op->argsz = sizeof(*pe_op) + sizeof(*pe_err);

Surely that argsz can't be correct for most of the operations. The
extended structure should only be there for the error inject ioctl,
yes?

--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]