From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH kvm-unit-test] x86/emulator: Fix inline assembler warning
Date: Thu, 12 Mar 2015 22:13:04 -0300 [thread overview]
Message-ID: <20150313011304.GD17648@amt.cnet> (raw)
In-Reply-To: <54FDE39B.9040504@siemens.com>
On Mon, Mar 09, 2015 at 07:16:59PM +0100, Jan Kiszka wrote:
> Code compiles to the same binary, but now with one warning less.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> x86/emulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/emulator.c b/x86/emulator.c
> index 0964e6a..e5c1c6b 100644
> --- a/x86/emulator.c
> +++ b/x86/emulator.c
> @@ -838,7 +838,7 @@ static void test_jmp_noncanonical(uint64_t *mem)
>
> exceptions = 0;
> handle_exception(GP_VECTOR, advance_rip_by_3_and_note_exception);
> - asm volatile ("jmp %0" : : "m"(*mem));
> + asm volatile ("jmp *%0" : : "m"(*mem));
> report("jump to non-canonical address", exceptions == 1);
> handle_exception(GP_VECTOR, 0);
> }
> --
> 2.1.4
Applied, thanks.
prev parent reply other threads:[~2015-03-13 1:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 18:16 [PATCH kvm-unit-test] x86/emulator: Fix inline assembler warning Jan Kiszka
2015-03-13 1:13 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313011304.GD17648@amt.cnet \
--to=mtosatti@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox