From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2] KVM: vmx: Set msr bitmap correctly if vcpu is in guest mode Date: Fri, 13 Mar 2015 09:25:02 -0300 Message-ID: <20150313122502.GA11309@amt.cnet> References: <1425450716-2216-1-git-send-email-fanwenyi0529@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: bsd@redhat.com, pbonzini@redhat.com, gleb@kernel.org, yang.z.zhang@intel.com, wanpeng.li@linux.intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jan.kiszka@web.de, yong.y.wang@linux.intel.com To: Wincy Van Return-path: Content-Disposition: inline In-Reply-To: <1425450716-2216-1-git-send-email-fanwenyi0529@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Mar 04, 2015 at 02:31:56PM +0800, Wincy Van wrote: > In commit 3af18d9c5fe9 ("KVM: nVMX: Prepare for using hardware MSR bitmap"), > we are setting MSR_BITMAP in prepare_vmcs02 if we should use hardware. This > is not enough since the field will be modified by following vmx_set_efer. > > Fix this by setting vmx_msr_bitmap_nested in vmx_set_msr_bitmap if vcpu is > in guest mode. > > Signed-off-by: Wincy Van Applied, thanks.