From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [Patch v5] x86: irq_comm: Add check for RH bit in kvm_set_msi_irq Date: Fri, 13 Mar 2015 16:48:18 +0100 Message-ID: <20150313154817.GB17349@potion.brq.redhat.com> References: <5502FEDB.3030606@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, gleb@kernel.org, pbonzini@redhat.com To: James Sullivan Return-path: Received: from mx1.redhat.com ([209.132.183.28]:35082 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932394AbbCMPsY (ORCPT ); Fri, 13 Mar 2015 11:48:24 -0400 Content-Disposition: inline In-Reply-To: <5502FEDB.3030606@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: 2015-03-13 09:14-0600, James Sullivan: > --- > Changes since v2: > * Added one time warning message when RH=3D1 > * Documented conflict between RH=3D1 and delivery mode > * Tidied code to check RH=3D1/DM=3D1 (remove bool phys, use if/el= se) > Changes since v3: > * Fixed logical error in RH=3D1/DM=3D1 check > * Aligned quotation blocks in multiline pr_warn_once argument > Changes since v4: > * Put error message string on single line Thanks, Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > diff --git a/arch/x86/kvm/irq_comm.c b/arch/x86/kvm/irq_comm.c > @@ -103,12 +103,24 @@ static inline void kvm_set_msi_irq(struct kvm_k= ernel_irq_routing_entry *e, > + if (e->msi.address_lo & MSI_ADDR_REDIRECTION_LOWPRI) > + pr_warn_once( > + "kvm: MSIs may not be correctly delivered with RH set.\n"); (The joys of 80+ columns!)