From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH/RFC 3/9] KVM: s390: Fix low-address protection for real addresses Date: Mon, 16 Mar 2015 13:48:51 +0100 Message-ID: <20150316134851.4cbf9a67.cornelia.huck@de.ibm.com> References: <1426495905-17531-1-git-send-email-borntraeger@de.ibm.com> <1426495905-17531-4-git-send-email-borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: KVM , Paolo Bonzini , Marcelo Tosatti , Alexander Graf , Jens Freimann , Alexander Yarygin , Thomas Huth To: Christian Borntraeger Return-path: Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:50651 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754208AbbCPMs6 (ORCPT ); Mon, 16 Mar 2015 08:48:58 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Mar 2015 12:48:57 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 890062190046 for ; Mon, 16 Mar 2015 12:48:44 +0000 (GMT) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2GCmsqp65470668 for ; Mon, 16 Mar 2015 12:48:54 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2GCmqO2009761 for ; Mon, 16 Mar 2015 06:48:54 -0600 In-Reply-To: <1426495905-17531-4-git-send-email-borntraeger@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 16 Mar 2015 09:51:39 +0100 Christian Borntraeger wrote: > From: Alexander Yarygin > > The kvm_s390_check_low_addr_protection() function is used only with real > addresses. According to the POP (the "Low-Address Protection" > paragraph in chapter 3), if the effective address is real or absolute, > the low-address protection procedure should rise PROTECTION exception s/rise/raise a/ > only when the low-address protection is enabled in the control register > 0 and the address is low. > This patch removes ASCE checks from the function and renames it to > better reflect its behavior. > > Cc: Thomas Huth > Signed-off-by: Alexander Yarygin > Reviewed-by: Thomas Huth > Reviewed-by: David Hildenbrand > Signed-off-by: Christian Borntraeger > --- > arch/s390/kvm/gaccess.c | 11 ++++++----- > arch/s390/kvm/gaccess.h | 2 +- > arch/s390/kvm/priv.c | 4 ++-- > 3 files changed, 9 insertions(+), 8 deletions(-) Acked-by: Cornelia Huck