From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: Re: [PATCH/RFC 9/9] KVM: s390: Create ioctl for Getting/Setting
 guest storage keys
Date: Mon, 16 Mar 2015 14:07:31 +0100
Message-ID: <20150316140731.38487441.cornelia.huck@de.ibm.com>
References: <1426495905-17531-1-git-send-email-borntraeger@de.ibm.com>
	<1426495905-17531-10-git-send-email-borntraeger@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: KVM <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	Jens Freimann <jfrei@linux.vnet.ibm.com>,
	"Jason J. Herne" <jjherne@linux.vnet.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:51895 "EHLO
	e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750822AbbCPNHi (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 16 Mar 2015 09:07:38 -0400
Received: from /spool/local
	by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <cornelia.huck@de.ibm.com>;
	Mon, 16 Mar 2015 13:07:36 -0000
Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 0ABC81B08069
	for <kvm@vger.kernel.org>; Mon, 16 Mar 2015 13:07:56 +0000 (GMT)
Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2GD7XMU4587952
	for <kvm@vger.kernel.org>; Mon, 16 Mar 2015 13:07:33 GMT
Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2GD7WfB007316
	for <kvm@vger.kernel.org>; Mon, 16 Mar 2015 07:07:33 -0600
In-Reply-To: <1426495905-17531-10-git-send-email-borntraeger@de.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 16 Mar 2015 09:51:45 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> From: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
> 
> Provide the KVM_S390_GET_SKEYS and KVM_S390_SET_SKEYS ioctl which can be used
> to get/set guest storage keys. This functionality is needed for live migration
> of s390 guests that use storage keys.
> 
> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
> Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  Documentation/virtual/kvm/api.txt |  58 ++++++++++++++++++
>  arch/s390/kvm/kvm-s390.c          | 122 ++++++++++++++++++++++++++++++++++++++
>  include/uapi/linux/kvm.h          |  14 +++++
>  3 files changed, 194 insertions(+)
> 

> @@ -791,6 +801,7 @@ struct kvm_ppc_smmu_info {
>  #define KVM_CAP_S390_VECTOR_REGISTERS 107
>  #define KVM_CAP_S390_MEM_OP 108
>  #define KVM_CAP_S390_USER_STSI 109
> +#define KVM_CAP_S390_SKEYS 110

Hm... did you forget to actually advertise this cap?

> 
>  #ifdef KVM_CAP_IRQ_ROUTING
>