From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH RESEND] KVM: nVMX: mask unrestricted_guest if disabled on L0 Date: Tue, 17 Mar 2015 22:09:23 -0300 Message-ID: <20150318010923.GA13570@amt.cnet> References: <1426597352-4115-1-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Kashyap Chamarthy , stable@vger.kernel.org To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Content-Disposition: inline In-Reply-To: <1426597352-4115-1-git-send-email-rkrcmar@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, Mar 17, 2015 at 02:02:32PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: > If EPT was enabled, unrestricted_guest was allowed in L1 regardless o= f > L0. L1 triple faulted when running L2 guest that required emulation. >=20 > Another side effect was 'WARN_ON_ONCE(vmx->nested.nested_run_pending)= ' > in L0's dmesg: > WARNING: CPU: 0 PID: 0 at arch/x86/kvm/vmx.c:9190 nested_vmx_vmexit= +0x96e/0xb00 [kvm_intel] () >=20 > Prevent this scenario by masking SECONDARY_EXEC_UNRESTRICTED_GUEST wh= en > the host doesn't have it enabled. >=20 > Fixes: 78051e3b7e35 ("KVM: nVMX: Disable unrestricted mode if ept=3D0= ") > Cc: stable@vger.kernel.org > Tested-By: Kashyap Chamarthy > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > --- > The resend Cc'd stable, as recommended by Bandan, and added Tested-b= y. Applied to master, thanks.