From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 0/3] KVM: Fix sparse warnings. Date: Tue, 17 Mar 2015 22:39:04 -0300 Message-ID: <20150318013904.GB13570@amt.cnet> References: <1426239586-1369-1-git-send-email-lixiubo@cmss.chinamobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: gleb@kernel.org, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, kvm@vger.kernel.org To: Xiubo Li Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34876 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932231AbbCRBjj (ORCPT ); Tue, 17 Mar 2015 21:39:39 -0400 Content-Disposition: inline In-Reply-To: <1426239586-1369-1-git-send-email-lixiubo@cmss.chinamobile.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Mar 13, 2015 at 05:39:43PM +0800, Xiubo Li wrote: > Using the command like: 'make C=1 xxxx', the sparse tool will complain > about warnings like: > > warning: symbol 'XXX' was not declared. Should it be static? > warning: Using plain integer as NULL pointer > ... > > And also, if the symbols will only used locally, shouldn't it be static? > > > Xiubo Li (3): > KVM: X86: Avoid using plain integer as NULL pointer warning. > KVM: X86: For the symbols used locally only should be static type. > KVM: For the symbols used locally only should be static type. Applied 1 and 2, thanks.